Implement default PlayerDisplayNameProvider API#803
Draft
TechnicJelle wants to merge 3 commits into
Draft
Conversation
TBlueF
reviewed
May 14, 2026
TBlueF
reviewed
May 21, 2026
| BmMap map = maps.get(id); | ||
| if (map != null) { | ||
| mapRequestHandler = new MapRequestHandler(map, serverInterface, pluginConfig, Predicate.not(pluginState::isPlayerHidden)); | ||
| mapRequestHandler = new MapRequestHandler(playerDisplayNameProvider, map, serverInterface, pluginConfig, Predicate.not(pluginState::isPlayerHidden)); |
Member
There was a problem hiding this comment.
Yeah .. so this wont work either, since the variable is not initialized here, and if you change the variable via API after bluemap is loaded, it won't update either.. 😅
I'll take a look at this in a bit, rn i don't like any of the "easy" solutions to pass the information through to the LivePlayerDataProvider correctly..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a default for the API added in BlueMap-Minecraft/BlueMapAPI#9
I'm not all too happy about it all yet, especially the locations of some things and what I had to pass into other places.
Also, the default implementation currently kind of sucks.
I'd be happy to get feedback on this!
Screenshots of this working
Addon plugin code